Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to winit 0.23 api #542

Merged
merged 2 commits into from
Oct 8, 2020
Merged

update to winit 0.23 api #542

merged 2 commits into from
Oct 8, 2020

Conversation

aentity
Copy link
Contributor

@aentity aentity commented Sep 29, 2020

WIP will change to winit 0.23 once crates.io is released

@hecrj hecrj added the feature New feature or request label Sep 30, 2020
@aentity
Copy link
Contributor Author

aentity commented Oct 3, 2020

Ready for review

@aentity
Copy link
Contributor Author

aentity commented Oct 4, 2020

@hecrj I think this is ready

@kaimast
Copy link

kaimast commented Oct 8, 2020 •
edited
Loading

I just tested your branch and it works flawlessly for me :)

It would be great if this could be merged quickly. Winit 0.23 fixes a large number of Wayland bugs among other improvements.

@VitalyAnkh
Copy link

I'm experiencing a compile error about wayland...

[wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting

Looking forwad to this.

hecrj
hecrj approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🎉

I have changed the KeyCode in 16cd38a to keep the names consistent with winit for now.

@hecrj hecrj added this to the 0.2.0 milestone Oct 8, 2020
@hecrj hecrj merged commit 2e0ba65 into iced-rs:master Oct 8, 2020
@aentity aentity deleted the winit_023 branch October 8, 2020 17:51
@valpackett valpackett mentioned this pull request Oct 18, 2020
Closed
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aentity @kaimast @VitalyAnkh @hecrj