Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to wgpu 0.7 #725

Merged
merged 16 commits into from
Feb 6, 2021
Merged

Update to wgpu 0.7 #725

merged 16 commits into from
Feb 6, 2021

Conversation

PolyMeilex
Copy link
Contributor

@PolyMeilex PolyMeilex commented Feb 3, 2021 •
edited by hecrj
Loading

Notes:

  • wgpu::PowerPreference::Default no longer exists, maybe there is another way to replicate its behavior.
  • Not sure if filtering sampler should be used. (so it is not used)
  • Anti-aliasig fix had to be removed because of wgpu ScissorRect validation error link

What is working:

  • bezier_tool
  • clock
  • color_palette
  • counter
  • custom_widget
  • download_progress
  • events
  • game_of_life
  • geometry
  • integration
  • pane_grid
  • pick_list
  • pokedex
  • progress_bar
  • qr_code
  • scrollable
  • solar_system
  • stopwatch
  • styling
  • svg
  • todos
  • tour

Closes #723.

@PolyMeilex
The beginning of wgpu 0.7 update
4a727df 
#723
@PolyMeilex
[wgpu 0.7] Update quad.rs
2d76c71
@PolyMeilex
[wgpu 0.7] Update window/compositor.rs
98d108d 
Notes:
- wgpu::PowerPreference::Default no longer exists, maybe there is another way to replicate its behavior.
@PolyMeilex
[wgpu 0.7] Update triangle/msaa.rs
5f935c3 
Notes:
- not sure if `filtering sampler` should be used, so for now it is not used
.
@PolyMeilex
[wgpu 0.7] Update triangle.rs
e2595ac
@PolyMeilex
[wgpu 0.7] Update image.rs
4a6db30
@PolyMeilex
[wgpu 0.7] triangle/msaa disable filtering
c5d6ddc
@PolyMeilex
Fix ScissorRect
bd6b830 
- Breaks `TODO: Address anti-aliasing adjustments properly`
@PolyMeilex
Fix TextureViewDimension for image
1fb60c5 
wgpu validation helped to find this long standing type error
@PolyMeilex
[wgpu 0.7] Update integration example
09a5348
@PolyMeilex PolyMeilex marked this pull request as ready for review February 3, 2021 21:47
@PolyMeilex
Change PowerPreference from default() to LowPower
b0d1be6 
There is no reason to hide the fact that this is always in `LowPower` mode
@hecrj hecrj added the feature New feature or request label Feb 6, 2021
@hecrj hecrj added this to the 0.3.0 milestone Feb 6, 2021
hecrj
hecrj approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you! 🎉

I have made some changes to fix a couple of details, but overall everything looks good! The most important ones are:

  • 5fc4210 which changes the wgpu_glyph dependency to rely on the latest release.
  • 74b9ea5 which enables the filtering flags in wgpu::image, since we use bilinear filtering there. I am not sure if this is correct, however. I didn't see any validation errors nor a difference in the rendered image.

In any case, I think we can merge this!

@hecrj hecrj merged commit 2f10a1f into iced-rs:master Feb 6, 2021
@PolyMeilex
Copy link
Contributor Author

Thanks

This was referenced Feb 12, 2021
Closed
Closed
yusdacra added a commit to yusdacra/iced that referenced this pull request Feb 22, 2021
@yusdacra
Revert "Merge pull request iced-rs#725 from PolyMeilex/wgpu-7.0"
2629e64 
This reverts commit 2f10a1f, reversing
changes made to 12c0c18.
yusdacra added a commit to yusdacra/iced that referenced this pull request Feb 25, 2021
@yusdacra
Revert "Merge pull request iced-rs#725 from PolyMeilex/wgpu-7.0"
2f2f78c 
This reverts commit 2f10a1f, reversing
changes made to 12c0c18.
yusdacra added a commit to yusdacra/iced that referenced this pull request Mar 6, 2021
@yusdacra
Revert "Merge pull request iced-rs#725 from PolyMeilex/wgpu-7.0"
8309209 
This reverts commit 2f10a1f, reversing
changes made to 12c0c18.
yusdacra added a commit to yusdacra/iced that referenced this pull request Mar 15, 2021
@yusdacra
Revert "Merge pull request iced-rs#725 from PolyMeilex/wgpu-7.0"
fba8ae9 
This reverts commit 2f10a1f, reversing
changes made to 12c0c18.
@13r0ck 13r0ck mentioned this pull request Mar 20, 2021
Open
@hecrj hecrj mentioned this pull request Mar 31, 2021
Merged
@mvilim mvilim mentioned this pull request May 22, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

update to wgpu 0.7
2 participants
@PolyMeilex @hecrj