Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for optional chaining #97

Closed
pmrotule opened this issue Jan 20, 2019 · 6 comments
Closed

No support for optional chaining #97

pmrotule opened this issue Jan 20, 2019 · 6 comments

Comments

@pmrotule
Copy link

Currently no support for optional chaining: https://babeljs.io/docs/en/babel-plugin-proposal-optional-chaining

Since it is now possible to use it with Babel, it would be great to be able to use it in Vue component.

image

@aidistan
Copy link
Contributor

Hi @pmrotule. Actually this issue has no relation to language-vue , since the support for optional chaining your need should be provided by the javascript language package you used. Give any package providing source.js.jsx grammar (like this) a try!

@pmrotule
Copy link
Author

pmrotule commented Jan 22, 2019

@aidistan I'm using the core package language-javascript which fully support optional chaining and indeed, I don't have any highlighting issue in normal javascript files. Moreover, the javascript itself within the script tag of the Vue single-file component has no highlighting issue or syntax error, it only breaks from the closing tag </script>. This must be an issue coming from language-vue.

image

@aidistan
Copy link
Contributor

@pmrotule You're right. It's comfirmed. I'm quite occupied in these days. Will look into it ASAP.

@pmrotule
Copy link
Author

@aidistan After looking into it a bit deeper, I realized that the problem is not coming from this package, but from embedded script. I mentioned that it was fully supported by language-javascript, but it actually only works properly in javascript files and not within a <script> tag in HTML.

language-vue use source.js.embedded.html and therefore has the same issue as any other html files. I reported it to language-javascript. Sorry about the confusion.

@aidistan
Copy link
Contributor

@pmrotule Thanks for this update 😄

@gVguy
Copy link

gVguy commented Feb 4, 2022

Any updates on this? I'm running into this problem too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants