Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] npm install for data-extraction doesn't work #22

Closed
Almenon opened this issue Feb 24, 2020 · 4 comments
Closed

[bug] npm install for data-extraction doesn't work #22

Almenon opened this issue Feb 24, 2020 · 4 comments

Comments

@Almenon
Copy link
Contributor

Almenon commented Feb 24, 2020

When I cd into data-extraction and run npm i I get the following error:

C:\dev\vscode-debug-visualizer\data-extraction>npm i
npm WARN deprecated tslint@6.0.0: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name "^[object Object]": Tags may not have any characters that encodeURIComponent encodes.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\almenon\AppData\Roaming\npm-cache\_logs\2020-02-24T05_47_11_520Z-debug.log

Then I tried yarn, which worked. (although it asked me to manually select the version of @types/d3)

The yarn.lock file has the following:

"@types/d3@^[object Object]":
  version "5.7.2"
  resolved "https://registry.yarnpkg.com/@types/d3/-/d3-5.7.2.tgz#52235eb71a1d3ca171d6dca52a58f5ccbe0254cc"
  integrity sha512-7/wClB8ycneWGy3jdvLfXKTd5SoTg9hji7IdJ0RuO9xTY54YpJ8zlcFADcXhY1J3kCBwxp+/1jeN6a5OMwgYOw==
  dependencies:
    "@types/d3-array" "^1"
    "@types/d3-axis" "*"
    "@types/d3-brush" "*"
    "@types/d3-chord" "*"
    "@types/d3-collection" "*"
    "@types/d3-color" "*"
    "@types/d3-contour" "*"
    "@types/d3-dispatch" "*"
    "@types/d3-drag" "*"
    "@types/d3-dsv" "*"
    "@types/d3-ease" "*"
    "@types/d3-fetch" "*"
    "@types/d3-force" "*"
    "@types/d3-format" "*"
    "@types/d3-geo" "*"
    "@types/d3-hierarchy" "*"
    "@types/d3-interpolate" "*"
    "@types/d3-path" "*"
    "@types/d3-polygon" "*"
    "@types/d3-quadtree" "*"
    "@types/d3-random" "*"
    "@types/d3-scale" "*"
    "@types/d3-scale-chromatic" "*"
    "@types/d3-selection" "*"
    "@types/d3-shape" "*"
    "@types/d3-time" "*"
    "@types/d3-time-format" "*"
    "@types/d3-timer" "*"
    "@types/d3-transition" "*"
    "@types/d3-voronoi" "*"
    "@types/d3-zoom" "*"

I still see object object in the lock file with yarn so I'm guessing that yarn runs into the same issue, it just doesn't warn you about it like npm. I'm not sure what's causing the object object thing :(

Can you commit your yarn.lock file please? Maybe that will help.

@hediet
Copy link
Owner

hediet commented Feb 24, 2020

I created a fresh package.json, only referencing @hediet/debug-visualizer-data-extraction and both yarn and npm just work fine. For the repository however, you have to use yarn, as I heavily rely on the yarn workspace feature.
Edit: Something strange is going on, I'm investigating.

@hediet
Copy link
Owner

hediet commented Feb 24, 2020

It's a known bug #microsoft/types-publisher#746. Hopefully fixed soon.

@hediet
Copy link
Owner

hediet commented Feb 24, 2020

Fixed on master by fixing plotly to 1.44.28.

@Almenon Almenon closed this as completed Feb 25, 2020
@Almenon
Copy link
Contributor Author

Almenon commented Feb 25, 2020

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants