Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Allow commit to be done via github bot #141

Closed
tielur opened this issue Jul 31, 2022 · 4 comments · Fixed by #154
Closed

Allow commit to be done via github bot #141

tielur opened this issue Jul 31, 2022 · 4 comments · Fixed by #154

Comments

@tielur
Copy link

tielur commented Jul 31, 2022

Would it be possible to allow a setting to make the commit to the deploy branch be the github bot?

Specifically here:
https://github.com/helaili/jekyll-action/blob/master/entrypoint.sh#L183-L184

I'd like to ideally set GITHUB_ACTOR to github-actions[bot]

There's a few other actions I've seen do this:
pypa/pipenv#4328
pypa/pipenv#4329

My main reasoning for wanting this is so that my github commit history doesn't get flooded by action commits

@tielur
Copy link
Author

tielur commented Jul 31, 2022

I'm more then happy to open a PR if this is something that makes sense

@itrich
Copy link

itrich commented Aug 1, 2022

I'm more then happy to open a PR if this is something that makes sense

Yes, that would be really awesome and from my point of view a great addition to this action. +1 for this feature!

Another action where this is implemented: https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-set-git-username-and-email

@UlyssesZh
Copy link

+1 for this feature request. Hope it will be implemented!

@tielur
Copy link
Author

tielur commented Nov 1, 2022

I have a fork that I made that I've been testing and it works well. I'll work on cleaning it up and open a PR soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants