Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config 2.0 follow up - change support commented out #1183

Closed
tomas-langer opened this issue Dec 5, 2019 · 0 comments · Fixed by #1417
Closed

Config 2.0 follow up - change support commented out #1183

tomas-langer opened this issue Dec 5, 2019 · 0 comments · Fixed by #1417
Assignees
@tomas-langer
Labels
2.x Issues for 2.x version branch bug Something isn't working config P2
Milestone
2.0.0

Comments

@tomas-langer
Copy link
Member

In AbstractConfigImpl, the lines 386-391 are commented out, as the change support as implemented right now fails.
As we plan to refactor this (#579), we can delay fixing this issue after the refactoring is done.
@tomas-langer tomas-langer added bug Something isn't working config labels Dec 5, 2019
@tomas-langer tomas-langer added this to the 2.0.0 milestone Dec 5, 2019
@tomas-langer tomas-langer mentioned this issue Dec 5, 2019
Merged
@tomas-langer tomas-langer mentioned this issue Dec 12, 2019
Closed
8 tasks
@m0mus m0mus added the P2 label Dec 12, 2019
@tomas-langer tomas-langer added the 2.x Issues for 2.x version branch label Jan 16, 2020
@tomas-langer tomas-langer self-assigned this Feb 3, 2020
@tomas-langer tomas-langer mentioned this issue Feb 6, 2020
Merged
@tomas-langer tomas-langer mentioned this issue Feb 20, 2020
Merged
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

Labels
2.x Issues for 2.x version branch bug Something isn't working config P2
Projects
Backlog
Archived in project
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Config change support refactoring tomas-langer/helidon
2 participants
@m0mus @tomas-langer