Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UCP connection pool support in dbclient #1589

Open
romain-grecourt opened this issue Mar 26, 2020 · 4 comments
Open

Add UCP connection pool support in dbclient #1589

romain-grecourt opened this issue Mar 26, 2020 · 4 comments
Assignees
Labels
DB client Helidon DB Client enhancement New feature or request P3

Comments

@romain-grecourt
Copy link
Contributor

Add UCP connection pool support in DBClient as an alternative to Hikari.
Also take the opportunity to review the API by trying to implement this in user space.

E.g.

DbClient dbClient = new JdbcDbClientProvider().builder()
    .config(config)
    .connectionPool(UCPConnectionPool.create(config))
    .build()
    .build();

The above snippet doesn't look right. We also need to make sure the programmatic way can be used to setup the connection.

@romain-grecourt
Copy link
Contributor Author

CC @Tomas-Kraus @tomas-langer

@romain-grecourt romain-grecourt added db DB client Helidon DB Client labels Mar 26, 2020
@tomas-langer
Copy link
Member

Now we can use JdbcDbClientProviderBuilder.create()

@m0mus m0mus added the P3 label Apr 2, 2020
@tomas-langer tomas-langer removed the db label May 13, 2020
@paulparkinson paulparkinson self-assigned this May 14, 2020
@danielkec
Copy link
Contributor

danielkec commented Sep 8, 2021

Also ability to setup UCP with SslContext and tns names would make integration with #3072 great.

UCPConnectionPool.builder()
  .sslContext(sslCtx) 
  .tnsNames(stringInMemory)
  ...
  .build()

Depends on #3384

@MohanramGovindarasu
Copy link

@arjav-desai : Just adding the comment to the existing bug. We are also using Helidon's dbclient obj for all the DB interactions. I don't see any methods which can accept "UCP" as the connection object from DbClient class(I can see only support for Hikari CP as of now in Helidon SE 4.0.2 SE version). It was recommended by helidon framework team to move from Hikari CP to UCP. This will definitely help us understand which JDBC connection pool would be relevant for our use case for both OP and k8's deployment. Also we are planning to include "Observability and tracing" as part of our next phase, so UCP support in dbclient will be very crucial for our product.

Note: The key selling point for our product is performance.

Please share your thoughts on this.

@barchetta barchetta added the enhancement New feature or request label Mar 13, 2024
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Normal priority in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB client Helidon DB Client enhancement New feature or request P3
Projects
Status: Normal priority
Development

No branches or pull requests

8 participants