Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS MP can incorrectly ignore annotation-provided CORS info #1681

Closed
tjquinno opened this issue Apr 22, 2020 · 0 comments · Fixed by #1682
Closed

CORS MP can incorrectly ignore annotation-provided CORS info #1681

tjquinno opened this issue Apr 22, 2020 · 0 comments · Fixed by #1682
Assignees
Labels
2.x Issues for 2.x version branch bug Something isn't working cors Related to CORS support
Milestone

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 2.x
  • Helidon MP
  • JDK version: n/a
  • OS: n/a
  • Docker version (if applicable): n/a

The CORS MP implementation - because of code shared with CORS SE - can incorrectly ignore CORS information provided by the annotation.

Various spots in the code check isActive to short-circuit the CORS processing but isActive fails to account for the presence of the secondary source for CORS information -- in the case of MP the annotation.

@tjquinno tjquinno added bug Something isn't working 2.x Issues for 2.x version branch cors Related to CORS support labels Apr 22, 2020
@tjquinno tjquinno added this to the 2.0.0 milestone Apr 22, 2020
@tjquinno tjquinno self-assigned this Apr 22, 2020
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch bug Something isn't working cors Related to CORS support
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant