Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async support to MP metrics support for inferred @SimplyTimed #2742

Closed
tjquinno opened this issue Feb 5, 2021 · 1 comment · Fixed by #2745
Closed

Add async support to MP metrics support for inferred @SimplyTimed #2742

tjquinno opened this issue Feb 5, 2021 · 1 comment · Fixed by #2745
Assignees
Labels
2.x Issues for 2.x version branch bug Something isn't working metrics MP P3

Comments

@tjquinno
Copy link
Member

tjquinno commented Feb 5, 2021

Environment Details

  • Helidon Version: 2.x
  • Helidon SE or Helidon MP MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

The MP spec contains an optional feature (which Helidon implements) for inferring a @SimplyTimed annotation on each JAX-RS endpoint.

The spec https://download.eclipse.org/microprofile/microprofile-metrics-2.3/microprofile-metrics-spec-2.3.html has a very brief reference to "async":

With an asynchronous request the timing that is tracked by the REST metric must incorporate the time spent by the asynchronous call.

Our implementation does not currently treat JAX-RS methods with @Suspended AsyncResponse parameters differently, although we pass the optional TCK.

The spec is slightly vague on this point; I've asked for clarification in the MP Google group and the MP metrics Gitter group.

@tjquinno tjquinno self-assigned this Feb 5, 2021
@tjquinno tjquinno added 2.x Issues for 2.x version branch metrics MP labels Feb 5, 2021
@tjquinno tjquinno added the bug Something isn't working label Feb 5, 2021
@m0mus m0mus added the P3 label Feb 5, 2021
@tjquinno
Copy link
Member Author

tjquinno commented Feb 8, 2021

Here is the Google groups conversation I started about this: https://groups.google.com/g/microprofile/c/pMiRRB4TJIk It confirms that, in this case, the metric data should include the entire operation, not simply the submission of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch bug Something isn't working metrics MP P3
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants