Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] - Tracing Test Fail #5487

Closed
dalexandrov opened this issue Nov 21, 2022 · 3 comments
Closed

[4.x] - Tracing Test Fail #5487

dalexandrov opened this issue Nov 21, 2022 · 3 comments
Assignees
Labels
4.x Version 4.x bug Something isn't working testing
Milestone

Comments

@dalexandrov
Copy link
Contributor

Intermittent:

io.helidon.tracing.tests.it1.OpentraceableClientE2ETest.e2e  Time elapsed: 0.358 s  <<< FAILURE!
java.lang.AssertionError: 
Expected: a collection with size <0>
     but: collection size was <1>
@tomas-langer
Copy link
Member

Failing (quite consistently) on local machine.
Disabling test.

@tomas-langer tomas-langer added bug Something isn't working and removed intermittent labels Nov 24, 2022
@tomas-langer tomas-langer modified the milestones: 4.0.0, 4.0.0-M1 Nov 24, 2022
@tomas-langer tomas-langer self-assigned this Nov 25, 2022
@tomas-langer
Copy link
Member

Test is now refactored, I will create a PR soon.

@tomas-langer
Copy link
Member

This should now be fixed. There was an interference from the other unit test, as it would create a span, activate it and then never closes the scope. I have refactored the filter tests to run on a different thread, so the thread local does not impact any other code.

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working testing
Projects
Archived in project
Development

No branches or pull requests

2 participants