Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of DBClient reactive to blocking in OCI examples #6890

Closed
Tracked by #6683 ...
spericas opened this issue May 24, 2023 · 4 comments
Closed
Tracked by #6683 ...

Replace usage of DBClient reactive to blocking in OCI examples #6890

spericas opened this issue May 24, 2023 · 4 comments
Assignees
Labels
DB client Helidon DB Client P2
Milestone

Comments

@spericas
Copy link
Member

spericas commented May 24, 2023

In 3.x the ATP OCI example had this:

createDbClient(walletContent)
        .flatMap(dbClient -> dbClient.execute(exec -> exec.query("SELECT 'Hello world!!' FROM DUAL")))
        .first()
        .map(dbRow -> dbRow.column(1).as(String.class))
        .ifEmpty(() -> res.status(404).send())
        .onError(res::send)
        .forSingle(res::send);

Requires #6991

However, since #6991 is in progress, let's update the usage to use .await() to block.

@spericas spericas mentioned this issue May 24, 2023
57 tasks
@spericas spericas self-assigned this May 24, 2023
@spericas
Copy link
Member Author

This one relates to other OCI example issues (#6872 and #6873).

@aserkes I'll assign this one to you as it relates to the others. Feel free to assign it back to me if after moving examples to Nima, we still need to replace DbClient.

@romain-grecourt
Copy link
Contributor

romain-grecourt commented May 24, 2023

We've decided to update DBClient to blocking, thus we should not update all usages of DBClient. In the mean time we can use .await() on the Single and Multi instead of using JDBC directly.

@spericas spericas changed the title Replace usage of DBClient with plain JDBC Replace usage of DBClient reactive to blocking May 24, 2023
@spericas
Copy link
Member Author

@romain-grecourt Roger, title updated.

@m0mus m0mus added this to the 4.0.0-M1 milestone May 25, 2023
@m0mus m0mus added DB client Helidon DB Client P2 labels May 25, 2023
@romain-grecourt romain-grecourt changed the title Replace usage of DBClient reactive to blocking Replace usage of DBClient reactive to blocking in OCI examples May 25, 2023
@romain-grecourt
Copy link
Contributor

Fixed in #6859

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB client Helidon DB Client P2
Projects
Archived in project
Development

No branches or pull requests

4 participants