Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore JSON support for metadata to metrics in 4.x #7182

Closed
Tracked by #7193
tjquinno opened this issue Jul 13, 2023 · 1 comment
Closed
Tracked by #7193

Restore JSON support for metadata to metrics in 4.x #7182

tjquinno opened this issue Jul 13, 2023 · 1 comment
Assignees
Milestone

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The MP Metrics 5.0 spec removes the requirement for (and definition of) JSON format for metrics data and metadata.

Still, the JSON format prescribed by earlier MP metrics specs (and implemented in earlier releases of Helidon) is in some ways clearer and easier to work with than the Prometheus exposition format. Further, some of our tests use the JSON format.

PR #7139 for issue #5816 preserves JSON support for metrics data but not metadata. This issue represents restoring the JSON support for metadata.

@tjquinno tjquinno added metrics 4.x Version 4.x labels Jul 13, 2023
@tjquinno tjquinno added this to the 4.0.0-M2 milestone Jul 13, 2023
@tjquinno tjquinno self-assigned this Jul 13, 2023
@tjquinno tjquinno changed the title Restore full JSON support to metrics in 4.x Restore JSON support for metadata to metrics in 4.x Jul 13, 2023
@tjquinno
Copy link
Member Author

Changes for this are in the big metrics PR.

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants