Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.5 - Not able to propagate baggage using helidon-tracing-jaeger for active Span #8504

Closed
RickyFrost opened this issue Mar 20, 2024 · 8 comments · Fixed by #8512
Closed
Assignees
Labels
4.x Version 4.x bug Something isn't working P2 tracing
Milestone

Comments

@RickyFrost
Copy link

RickyFrost commented Mar 20, 2024

Environment Details

  • Helidon Version: 4.0.5
  • Helidon SE
  • JDK version: 21
  • OS: OL7

No longer able to propagate baggage items in 4.0.5 in jaeger provider, was able since 3.2.2

Problem Description

Identical problem and test case as #7018
I'm able to set and get baggage items locally, but injecting them provides no baggage to server.

Steps to reproduce

See test in #7018. Identical scenario and outcome.

@romain-grecourt romain-grecourt changed the title 7018 has recurred in 4.0.5 4.0.5 - Not able to propagate baggage using helidon-tracing-jaeger Mar 20, 2024
@romain-grecourt romain-grecourt added bug Something isn't working tracing 4.x Version 4.x labels Mar 20, 2024
@m0mus m0mus added the P2 label Mar 21, 2024
@m0mus m0mus added this to the 4.0.7 milestone Mar 21, 2024
@tjquinno
Copy link
Member

I cannot reproduce this problem.

Note that propagating the baggage to headers should yield a header with name baggage and a value mykey=myvalue (with a longer string if more baggage entries had been set). The test in the other issue (as written, at least) searches the headers for mykey which will not be there.

I verified the correct behavior by writing a new Jaeger unit test. I plan to create a PR to add the test, but from what I see there is no bug here to fix.

Side note: when testing Jaeger propagation (or OTel propagation which underlies Jaeger prop) several OTel dependencies need to be present and config settings assigned to avoid gettin a no-op OTel propagator. This will be evident in the test PR!

@tjquinno
Copy link
Member

@RickyFrost I should ask, are you seeing this problem in a running app or just in a test?

@RickyFrost
Copy link
Author

On Helidon 3.x SE code base:
I added the below to the top of my dependency management in pom.xml and tried our tracing regression tests with 3.2.2, 3.2.3, 3.2.4, 3.2.5, and 3.2.6.
-- All work except 3.2.6 which has the same problem as Helidon SE 4.0.5/4.0.6. Hope that helps.

        <dependency>
            <groupId>io.helidon</groupId>
            <artifactId>helidon-bom</artifactId>
            <version>3.2.2</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>

@RickyFrost
Copy link
Author

@RickyFrost
Copy link
Author

@tjquinno
Copy link
Member

In a Zoom session Ricky and I saw that the test that fails activates the span before checking the propagation. That's a difference from the test in the older issue and a different in the local test I created.

The propagation does not create the expected headers because the span context that is used to do the propagation does not have baggage, even though the baggage was set.

@al3xandru
Copy link

For tracking purposes and to understand the difference between this and #7018, I'd find it very useful to have an updated code snippet in the description/this thread.

@RickyFrost
Copy link
Author

@RickyFrost RickyFrost changed the title 4.0.5 - Not able to propagate baggage using helidon-tracing-jaeger 4.0.5 - Not able to propagate baggage using helidon-tracing-jaeger for active Span Mar 25, 2024
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working P2 tracing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants