-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.5 - Not able to propagate baggage using helidon-tracing-jaeger for active Span #8504
Comments
I cannot reproduce this problem. Note that propagating the baggage to headers should yield a header with name I verified the correct behavior by writing a new Jaeger unit test. I plan to create a PR to add the test, but from what I see there is no bug here to fix. Side note: when testing Jaeger propagation (or OTel propagation which underlies Jaeger prop) several OTel dependencies need to be present and config settings assigned to avoid gettin a no-op OTel propagator. This will be evident in the test PR! |
@RickyFrost I should ask, are you seeing this problem in a running app or just in a test? |
On Helidon 3.x SE code base:
|
In a Zoom session Ricky and I saw that the test that fails activates the span before checking the propagation. That's a difference from the test in the older issue and a different in the local test I created. The propagation does not create the expected headers because the span context that is used to do the propagation does not have baggage, even though the baggage was set. |
For tracking purposes and to understand the difference between this and #7018, I'd find it very useful to have an updated code snippet in the description/this thread. |
Environment Details
No longer able to propagate baggage items in 4.0.5 in jaeger provider, was able since 3.2.2
Problem Description
Identical problem and test case as #7018
I'm able to set and get baggage items locally, but injecting them provides no baggage to server.
Steps to reproduce
See test in #7018. Identical scenario and outcome.
The text was updated successfully, but these errors were encountered: