Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose unwrap on Helidon metrics API builder types #8586

Closed
tjquinno opened this issue Mar 29, 2024 · 0 comments · Fixed by #8588
Closed

Expose unwrap on Helidon metrics API builder types #8586

tjquinno opened this issue Mar 29, 2024 · 0 comments · Fixed by #8588
Assignees
Labels
4.x Version 4.x enhancement New feature or request metrics P2
Milestone

Comments

@tjquinno
Copy link
Member

tjquinno commented Mar 29, 2024

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The Helidon neutral metrics API exposes an abstraction of metrics behavior, similar to but not identical to Micrometer's approach.

We did not intend to include every feature of Micrometer in the Helidon API but by implementingunwrap allow developers relatively easy access to Micrometer features (or features of other potential implementations) not included in our neutral API.

The main level types (for example Counter and Timer) have unwrap but the builder types do not and it would be helpful if they did.

@tjquinno tjquinno added enhancement New feature or request metrics 4.x Version 4.x labels Mar 29, 2024
@tjquinno tjquinno self-assigned this Mar 29, 2024
@tjquinno tjquinno changed the title Make sure Helidon metrics API types expose unwrap - builders too Expose unwrap on Helidon metrics API builder types Mar 29, 2024
@tjquinno tjquinno added this to the 4.0.7 milestone Mar 29, 2024
@tjquinno tjquinno added the P2 label Mar 29, 2024
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x enhancement New feature or request metrics P2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant