Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

When sending final block sync bundle, indicate if the last batch of blocks is 'final' #1273

Open
Vagabond opened this issue Mar 4, 2022 · 1 comment · May be fixed by #1282
Open

When sending final block sync bundle, indicate if the last batch of blocks is 'final' #1273

Vagabond opened this issue Mar 4, 2022 · 1 comment · May be fixed by #1282
Assignees
@joecaswell

Comments

@Vagabond
Copy link
Contributor

Vagabond commented Mar 4, 2022

Currently the block sender does not indicate if the final batch of blocks sent is all the block the far end has. Adding a flag to the protocol and having the client check for that to inform further sync behaviour would be useful. Currently the node waits for a new block hash gossip to try to sync again, which may take several minutes.
@Vagabond
Copy link
Contributor Author

Vagabond commented Mar 4, 2022

Additionally, if the last block is not a final block, the node does not need to "eagerly gossip" it.

This was referenced Mar 15, 2022
Closed
Open
@joecaswell joecaswell mentioned this issue Jul 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joecaswell joecaswell

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Vagabond @joecaswell