Skip to content

Commit 03bfc2a

Browse files
committed
Enhance transaction notification
1 parent 240d473 commit 03bfc2a

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

src/components/transfer-v2.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ function Component() {
176176
const receipt = await approve(
177177
fee?.token.type === "native" ? deferredAmount.value : deferredAmount.value + (fee?.value ?? 0n),
178178
);
179-
notifyTransaction(receipt, sourceChain);
179+
notifyTransaction(receipt, sourceChain, "Approval");
180180
} else if (actionText === "Transfer") {
181181
setIsOpen(true);
182182
}
@@ -203,7 +203,7 @@ function Component() {
203203
withdrawNonce: BigInt(relayInfo?.withdrawNonce ?? 0),
204204
depositedMargin: BigInt(relayInfo?.margin ?? 0),
205205
});
206-
notifyTransaction(receipt, sourceChain);
206+
notifyTransaction(receipt, sourceChain, "Transfer");
207207
setTxHash(receipt?.transactionHash);
208208
if (receipt?.status === "success") {
209209
setIsTransfering(false);

src/providers/relayer-provider-v3.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
124124
if (address) {
125125
try {
126126
const receipt = await bridgeInstance.sourceApprove(amount, address);
127-
notifyTransaction(receipt, bridgeInstance.getSourceChain());
127+
notifyTransaction(receipt, bridgeInstance.getSourceChain(), "Approval");
128128
setSourceAllowance(await bridgeInstance.getSourceAllowance(address));
129129
return receipt;
130130
} catch (err) {
@@ -141,7 +141,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
141141
if (address) {
142142
try {
143143
const receipt = await bridgeInstance.targetApprove(amount, address);
144-
notifyTransaction(receipt, bridgeInstance.getTargetChain());
144+
notifyTransaction(receipt, bridgeInstance.getTargetChain(), "Approval");
145145
setTargetAllowance(await bridgeInstance.getTargetAllowance(address));
146146
return receipt;
147147
} catch (err) {
@@ -169,7 +169,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
169169
async (amount: bigint) => {
170170
try {
171171
const receipt = await bridgeInstance.depositPenaltyReserve(amount);
172-
notifyTransaction(receipt, bridgeInstance.getSourceChain());
172+
notifyTransaction(receipt, bridgeInstance.getSourceChain(), "Deposite");
173173
if (receipt?.status === "success") {
174174
await _updatePenaltyReserves();
175175
if (address) {
@@ -190,7 +190,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
190190
async (baseFee: bigint, feeRate: number, transferLimit: bigint) => {
191191
try {
192192
const receipt = await bridgeInstance.registerLnProvider(baseFee, feeRate, transferLimit);
193-
notifyTransaction(receipt, bridgeInstance.getSourceChain());
193+
notifyTransaction(receipt, bridgeInstance.getSourceChain(), "Register");
194194
return receipt;
195195
} catch (err) {
196196
console.error(err);
@@ -204,7 +204,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
204204
async (amount: bigint) => {
205205
try {
206206
const receipt = await bridgeInstance.withdrawPenaltyReserve(amount);
207-
notifyTransaction(receipt, bridgeInstance.getSourceChain());
207+
notifyTransaction(receipt, bridgeInstance.getSourceChain(), "Withdraw");
208208

209209
if (receipt?.status === "success") {
210210
await _updatePenaltyReserves();
@@ -231,7 +231,7 @@ export default function RelayerProviderV3({ children }: PropsWithChildren<unknow
231231
messageFee,
232232
params ?? address,
233233
);
234-
notifyTransaction(receipt, bridgeInstance.getTargetChain());
234+
notifyTransaction(receipt, bridgeInstance.getTargetChain(), "Withdraw");
235235
return receipt;
236236
} catch (err) {
237237
console.error(err);

src/providers/relayer-provider.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ export default function RelayerProvider({ children }: PropsWithChildren<unknown>
226226
const sourceApprove = useCallback(async (owner: Address, amount: bigint, bridge: BaseBridge, chain: ChainConfig) => {
227227
try {
228228
const receipt = await bridge.sourceApprove(amount, owner);
229-
notifyTransaction(receipt, chain);
229+
notifyTransaction(receipt, chain, "Approval");
230230
setSourceAllowance(await bridge.getSourceAllowance(owner));
231231
return receipt;
232232
} catch (err) {
@@ -238,7 +238,7 @@ export default function RelayerProvider({ children }: PropsWithChildren<unknown>
238238
const targetApprove = useCallback(async (owner: Address, amount: bigint, bridge: BaseBridge, chain: ChainConfig) => {
239239
try {
240240
const receipt = await bridge.targetApprove(amount, owner);
241-
notifyTransaction(receipt, chain);
241+
notifyTransaction(receipt, chain, "Approval");
242242
setTargetAllowance(await bridge.getTargetAllowance(owner));
243243
return receipt;
244244
} catch (err) {
@@ -254,7 +254,7 @@ export default function RelayerProvider({ children }: PropsWithChildren<unknown>
254254
async (relayer: Address, margin: bigint, bridge: LnBridgeV2Default, chain: ChainConfig) => {
255255
try {
256256
const receipt = await bridge.depositMargin(margin);
257-
notifyTransaction(receipt, chain);
257+
notifyTransaction(receipt, chain, "Deposite");
258258

259259
const a = await bridge.getTargetAllowance(relayer);
260260
const b = await bridge.getTargetBalance(relayer);
@@ -327,7 +327,7 @@ export default function RelayerProvider({ children }: PropsWithChildren<unknown>
327327
) => {
328328
try {
329329
const receipt = await bridge.withdrawMargin(recipientOrParams, amount, fee);
330-
notifyTransaction(receipt, chain);
330+
notifyTransaction(receipt, chain, "Withdraw");
331331
return receipt;
332332
} catch (err) {
333333
console.error(err);

src/providers/transfer-provider.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export default function TransferProvider({ children }: PropsWithChildren<unknown
136136
) => {
137137
try {
138138
const receipt = await bridge.transfer(sender, recipient, amount, options);
139-
notifyTransaction(receipt, chain);
139+
notifyTransaction(receipt, chain, "Transfer");
140140

141141
const a = await bridge.getSourceAllowance(sender);
142142
const b = await bridge.getSourceBalance(sender);
@@ -155,7 +155,7 @@ export default function TransferProvider({ children }: PropsWithChildren<unknown
155155
const sourceApprove = useCallback(async (owner: Address, amount: bigint, bridge: BaseBridge, chain: ChainConfig) => {
156156
try {
157157
const receipt = await bridge.sourceApprove(amount, owner);
158-
notifyTransaction(receipt, chain);
158+
notifyTransaction(receipt, chain, "Approval");
159159
setSourceAllowance(await bridge.getSourceAllowance(owner));
160160
return receipt;
161161
} catch (err) {

src/utils/notification.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,24 @@ function Link({ href, children }: PropsWithChildren<{ href: string }>) {
1111
);
1212
}
1313

14-
export function notifyTransaction(receipt?: TransactionReceipt, chain?: ChainConfig) {
14+
export function notifyTransaction(receipt?: TransactionReceipt, chain?: ChainConfig, title?: string) {
1515
const explorer = chain?.blockExplorers?.default.url;
1616
const txHash = receipt?.transactionHash;
1717
const href = new URL(`tx/${txHash}`, explorer).href;
1818

1919
if (receipt?.status === "success" && txHash) {
2020
notification.success({
21-
title: "Transaction successful",
21+
title: `${title ?? "Transaction"} successful`,
2222
description: <Link href={href}>{txHash}</Link>,
2323
});
2424
} else if (receipt?.status === "reverted" && explorer) {
2525
notification.error({
26-
title: "Transaction failed",
26+
title: `${title ?? "Transaction"} failed`,
2727
description: <Link href={href}>{txHash}</Link>,
2828
});
2929
}
3030
}
3131

3232
export function notifyError(err: unknown) {
33-
return notification.error({ title: "An error occurred", description: (err as Error).message });
33+
return notification.error({ title: "Oops an error occurred", description: (err as Error).message });
3434
}

0 commit comments

Comments
 (0)