-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake.nix: we should report a more accurate version string in --version #1700
Comments
It reads the git sha, then falls back to only using the package version here: Lines 5 to 15 in e1a92fd
But that will work incorrectly if building outside of the helix repository but inside a package workspace (e.g. nixpkgs or alpine's git repository) so we need to include https://github.com/tree-sitter/tree-sitter/blob/af00782dfdad02f766a76058e8631cb4edf5d894/cli/build.rs#L36-L81 We could modify |
Now with the 22.03 release:
🎉 (see #1875) |
We can't include the git sha in the flake output because of how Nix builds. It's either in a bare directory or not in a git directory at all (I'm not sure which), so |
Hello.
I'm running
hx
from the flake and want to be a good bug reported and include my version string. However, I know right now that the tip-flake-built hx doesn't report the correct version.Depending on how the app is written, this can be easy (patch a constant) or hard (patch a constant and then find out that clap is ignoring the constant and reaching in the cargo metadata anyway).
The text was updated successfully, but these errors were encountered: