Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate items in the command palette menu #2221

Closed
Zoybean opened this issue Apr 22, 2022 · 4 comments
Closed

Duplicate items in the command palette menu #2221

Zoybean opened this issue Apr 22, 2022 · 4 comments
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug

Comments

@Zoybean
Copy link
Contributor

Zoybean commented Apr 22, 2022

Summary

There's a duplicate goto line end and extend to line end item in the space+? menu

Reproduction Steps

I tried this:

  1. hx
  2. space+?
  3. search to line end

I expected this to happen:

items:
Extend to line end
Goto line end (end, g+l)

Instead, this happened:

items:
Extend to line end
Extend to line end
Goto line end (end, g+l)
Goto line end

Helix log

~/.cache/helix/helix.log
2022-04-20T22:21:45.065 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-20T22:27:01.451 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-20T22:33:07.453 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-20T22:46:55.017 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { LSP not defined }
2022-04-20T22:49:27.147 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { LSP not defined }
2022-04-21T21:56:20.377 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T21:56:20.901 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:01:45.234 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:03:57.103 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:04:44.111 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:06:01.560 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:31:17.349 helix_lsp::transport [ERROR] <- Server error: content modified
2022-04-21T22:42:59.186 helix_lsp::transport [ERROR] <- Server error: content modified

Platform

Windows (WSL: ubuntu)

Terminal Emulator

Windows Terminal Version: 1.12.10732.0

Helix Version

22.03-115-g35d26936

@Zoybean Zoybean added the C-bug Category: This is a bug label Apr 22, 2022
@kirawi kirawi added the A-documentation Area: Documentation improvements label Apr 22, 2022
@Zoybean
Copy link
Contributor Author

Zoybean commented Apr 23, 2022

Update: There is also a duplicate entry for goto next/prev buffer

@sudormrfbin sudormrfbin changed the title duplicate items in the command menu Duplicate items in the command palette menu Apr 23, 2022
@matoous
Copy link
Contributor

matoous commented May 3, 2022

This happens because for example Goto previous buffer has both typeable command (:buffer-previous) as well as mappable command (goto_previous_buffer). I am not sure what the ideal solution here should be, maybe we could just distinguish typeable and mappable commands in the command palette?

@Zoybean
Copy link
Contributor Author

Zoybean commented May 3, 2022

In that case, perhaps the full command invocation could be given for : commands, like how the key sequence is shown for mapped commands?
So, sample output:

Goto next buffer (g+n)
Go to next buffer (:buffer-previous)
Goto previous buffer (g+p)
Go to previous buffer (:buffer-next)

@the-mikedavis
Copy link
Member

Fixed in #4071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants