Auto close matching pair feature causes corruption with nested quotes (edge case)

[aral]

Summary

When multiple cursors are active around a string with nested quotes and you change the quote characters, the auto-close matching pair feature results in corrupted code.

Reproduction Steps

const a = 'hello "there"'

1. Select opening single quote /' return
2. Extend selection v
3. Select next single quote n
4. Change the quotes c
5. Enter backtick `

What should happen

The two single quotes should be replaced by backticks:

const a = `hello "there"`

What actually happens

The two quotes are replaced by backticks and an additional backtick is added to the end:

const a = `hello "there"``

Helix log

n/a

Platform

Linux

Terminal Emulator

GNOME Terminal

Helix Version

helix 22.05-dev (3a398ee)

[archseer]

@dead10ck maybe? I think it falls under auto-pairs

[dead10ck]

Sorry to be this person, but... this doesn't seem like a bug to me? You have a case where there are two independent cursors in insert mode, so each are going to insert their own auto pairs. Neither are aware of the other. The first cursor does not auto pair in this case because it happens to precede an alpha character.

I think what you want here is mc'` or even just r`

[archseer]

Ah yep, r` is what I'd suggest