Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid regex" message not shown on enter #3034

Closed
A-Walrus opened this issue Jul 11, 2022 · 0 comments · Fixed by #3049
Closed

"Invalid regex" message not shown on enter #3034

A-Walrus opened this issue Jul 11, 2022 · 0 comments · Fixed by #3049
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@A-Walrus
Copy link
Contributor

Summary

When selecting/searching with an invalid regex pattern, the "Invalid regex" prompt is only shown once you hit n (next), and not on enter.

Reproduction Steps

I tried this:

  1. type some text
  2. select the text
  3. use regex select command with s
  4. type an invalid regex pattern (ie [)
  5. hit enter

I expected this to happen:
I see the message Invalid regex: [ at the bottom

Instead, this happened:
I don't see the message until I hit n to go to next selection

Helix log

~/.cache/helix/helix.log
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Linux

Terminal Emulator

Kitty

Helix Version

helix 22.05

@A-Walrus A-Walrus added the C-bug Category: This is a bug label Jul 11, 2022
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants