Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-z in nushell sends the terminal into an unusable state. #3761

Closed
cyanic-selkie opened this issue Sep 9, 2022 · 3 comments
Closed

Ctrl-z in nushell sends the terminal into an unusable state. #3761

cyanic-selkie opened this issue Sep 9, 2022 · 3 comments
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@cyanic-selkie
Copy link

Summary

Nushell doesn't have moving processes to background/foreground implemented yet and therefore Ctrl-z shouldn't do anything - this is how other software I tried behaves.

However, helix seemingly "exits" and leaves the terminal in an unusable state. Furthermore, killing the terminal leaves the helix process running in the background.

I tried testing this on alacritty with both nushell and bash. Everything works as expected in bash where background/foreground is implemented.

Reproduction Steps

I tried this:

  1. nu
  2. hx
  3. Ctrl-z

I expected this to happen:
Nothing.

Instead, this happened:
Helix seemingly "exited" and left the terminal in an unusable state. Killing the terminal left the helix process running in the background.

Helix log

~/.cache/helix/helix.log empty

Platform

Linux

Terminal Emulator

alacritty 0.10.1-2

Helix Version

helix 22.08.1 (59f7b07)

@cyanic-selkie cyanic-selkie added the C-bug Category: This is a bug label Sep 9, 2022
@cyanic-selkie cyanic-selkie changed the title Ctrl-z in nushell send the terminal into an unusable state. Ctrl-z in nushell sends the terminal into an unusable state. Sep 9, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Sep 9, 2022
@the-mikedavis
Copy link
Member

This might be fixed by #3322 or #3546

Could you try suspending from nushell with either of those?

@cyanic-selkie
Copy link
Author

cyanic-selkie commented Sep 10, 2022

Indeed, #3322 works. Hitting Ctrl-Z triggers the following message in the statusline: "Suspend is not supported by this terminal."

#3546 has no effect.

@the-mikedavis
Copy link
Member

Ah, seems like nushell has the same suspend behavior as elvish then. Let's close this in favor of #3321

@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants