Workspace root and LSP root should be handled differently #3993
Labels
A-core
Area: Helix core improvements
A-language-server
Area: Language server client
C-enhancement
Category: Improvements
E-easy
Call for participation: Experience needed to fix: Easy / not much
E-good-first-issue
Call for participation: Issues suitable for new contributors
In many larger projects, there are multiple languages working together, usually with some nice folder structure going on. Sometimes these are in separate git folders, and sometimes they are large monorepositories. Before #3929 this was achievable with a marker folder
.helix/languages.toml
that could specifiy a small projects Language Server (LS) on a directory basis. While the Helix root was specified as the correct path.After the change, now the root for the helix editor and the LS are the same, creating issues with folder structure like this:
In these cases if opening helix in one of the rust projects folders, the root will be
workspace root
, initiating the LSP where there are no Cargo.toml file and thus the LS will fail. Creating a Cargo.toml workspace could have been a solution, but in that case, the different targets like wasm/native can start to mess things up, and cargo workspaces does not handle this.Enabling the LSP to define where it is started by a marker folder as before would help.
related isses that probably would be solved by allowing this:
The text was updated successfully, but these errors were encountered: