Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for lsp Diagnostic.data #4934

Closed
sigmaSd opened this issue Nov 29, 2022 · 0 comments · Fixed by #4935
Closed

Add support for lsp Diagnostic.data #4934

sigmaSd opened this issue Nov 29, 2022 · 0 comments · Fixed by #4935
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented Nov 29, 2022 •
edited
Loading

Summary

It already has a TODO here https://github.com/helix-editor/helix/blob/master/helix-lsp/src/lib.rs

But I thought I raise an issue, since it has a real world usage: deno uses this for import code action https://github.com/denoland/deno/blob/e4fe5ee72ace30ccd1b7b6b15717164cf79f49c4/cli/lsp/diagnostics.rs#L660
@sigmaSd sigmaSd added the C-bug Category: This is a bug label Nov 29, 2022
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-language-server Area: Language server client and removed C-bug Category: This is a bug labels Nov 29, 2022
@sigmaSd sigmaSd mentioned this issue Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): add support for lsp Diagnostic{}.data sigmaSd/helix
2 participants
@the-mikedavis @sigmaSd