Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:sh tab completion cycles through directory names only, not file names or program names #5338

Closed
pbnj opened this issue Dec 29, 2022 · 2 comments · Fixed by #5729
Closed
Labels
C-bug Category: This is a bug

Comments

@pbnj
Copy link

pbnj commented Dec 29, 2022

Summary

Typing :sh followed by tab, helix shows and cycles through directory names only; it does not show files or cycle through them and it does not cycle through program names.

Here is a GIF demo:

  • :open shows the current files & folders available
  • :sh only sees folders
  • A common use-case is to :sh <program> <file_or_folder> but lack of tab completion for program names and file names cripples the :sh feature.

out

Reproduction Steps

In helix:

  • :sh <tab>

Helix log

N/A

Platform

macos

Terminal Emulator

terminal.app, chrome secure shell

Helix Version

helix 22.12 (96ff64a)

@pbnj pbnj added the C-bug Category: This is a bug label Dec 29, 2022
@the-mikedavis
Copy link
Member

It's currently configured to use the directory completer:

completer: Some(completers::directory),

I'm not sure why that completer is used vs the filename completer though (completers::filename)

@flaviu-toader
Copy link

What would be the expected behavior here? I would imagine also a completer that looks through things the user has in their $PATH to be useful.

@the-mikedavis the-mikedavis linked a pull request Jan 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants