Compilation error

[carstein]

Summary

Currently the project does not compile because of the 'ignore v0.4.19' package - this package requires 'scoped_threads' - an unstable feature that only stabilized in Rust 1.63. Unfortunatelly the rust-toolchain.toml overrides the current version down to 1.61. That causes the compilation to fail.

This can be fixed by bumping version up to at least 1.63.0

Reproduction Steps

$ git clone https://github.com/helix-editor/helix helix
$ cd helix
$ cargo install --path helix-term

Helix log

No response

Platform

Linux

Terminal Emulator

gnome-terminal

Helix Version

22.12-95-gf2fff9b9

[the-mikedavis]

ignore is currently locked at 0.4.18:

helix/Cargo.lock

Lines 1353 to 1355 in f2fff9b

	[[package]]
	name = "ignore"
	version = "0.4.18"

[carstein]

And yet ...
Compiling grep-searcher v0.1.11
Compiling ignore v0.4.19
Compiling grep-regex v0.1.11

[carstein]

After reading some more - cargo install by default ignores Cargo.lock - you can force the behaviour by running it with --locked

[the-mikedavis]

Oh interesting, I'm surprised that cargo behaves that way. The docs for installation from source should include the --locked flag to prevent this snag. Would you like to submit a PR?

[carstein]

Done: #5438

[pascalkuthe]

The next firefox release wil happen on 2023/1/17 so we can raise the MSRV to 1.63 soon to fix this problem (although encouraging the use of --locked is still good regardless)