Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for MSBuild files #5754

Closed
ghost opened this issue Jan 31, 2023 · 2 comments · Fixed by #5793
Closed

Add configuration for MSBuild files #5754

ghost opened this issue Jan 31, 2023 · 2 comments · Fixed by #5793
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR E-help-wanted Call for participation: Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jan 31, 2023

Currently, opening any MSBuild project file results in the default text language being used. At the least, the xml language should be used to gain proper highlighting. The file extensions I'm aware of are .csproj, .fsproj, .vbproj, and .proj.

It is, of course possible to work around this with :lang xml each time you open the file, and maybe other ways. However, I believe helix should provide this out of the box.

@sudormrfbin
Copy link
Member

sudormrfbin commented Jan 31, 2023

A PR for this would be definitely welcome, you can consult https://docs.helix-editor.com/master/guides/adding_languages.html on adding a new language entry. Re-using the xml grammar is a good starting point, and it can replaced with a dedicated tree-sitter grammar if it becomes available.

@sudormrfbin sudormrfbin added C-enhancement Category: Improvements E-help-wanted Call for participation: Extra attention is needed E-good-first-issue Call for participation: Issues suitable for new contributors A-language-support Area: Support for programming/text languages E-easy Call for participation: Experience needed to fix: Easy / not much labels Jan 31, 2023
@kirawi kirawi added the E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR label Jan 31, 2023
@ghost
Copy link
Author

ghost commented Feb 1, 2023

Related for XML support: https://github.com/eclipse/lemminx

This could bridge the gap for MSBuild project files, since a schema exists for them. I'm not sure if the schema is meant to be inferred or how that works, but that could be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants