autocompletion puts the cursor in the wrong place

[eulerdisk]

Summary

I think the new snippet based autocompletion has problems.
It put the cursor in the wrong place.
It seems to me it puts the cursor at the selection starting point. Is that the desired behavior?

See the asccinema.

Reproduction Steps

https://asciinema.org/a/RKvDTNf8i22Ufz2MBZlawshzI

Helix log

No response

Platform

WSL

Terminal Emulator

Windows Terminal

Helix Version

helix 22.12 (39d5fb0)

[archseer]

Fix is included in #5728 I think

[eulerdisk]

Fix is included in #5728 I think

👍 Almost.
The cursor is not place inside parenthesis if the auto-completed function has arguments.

[pascalkuthe]

This is indeed fixed by #5728, I can't reproduce the problem you mentinoed but I have some local fixes so it might be related to that

[eulerdisk]

This is indeed fixed by #5728, I can't reproduce the problem you mentinoned but I have some local fixes so it might be related to that

Nope. Cursor position is still going places randomly.
It's hard to reproduce though and it's a different problem than before.

[pascalkuthe]

This is indeed fixed by #5728, I can't reproduce the problem you mentinoned but I have some local fixes so it might be related to that

Nope. Cursor position is still going places randomly. It's hard to reproduce though and it's a different problem than before.

I tried the reproduction case you showed above and it works just fine now. I have spent a lot of time debugging this and I am fairly certain the cursor positioning should be correct now. Did you use the final version of that PR after it was merged (or in other words latest master)? I did a lot of additional work on that PR yesterday so it's possible you got an old version of that PR.

If you have found a different bug please open a new separate bug report.