Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP error message obscures my code. #7015

Closed
nathan-at-least opened this issue May 10, 2023 · 2 comments
Closed

LSP error message obscures my code. #7015

nathan-at-least opened this issue May 10, 2023 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@nathan-at-least
Copy link

Summary

First off, helix is awesome! So glad to have this project. Keep up the excellent work, everyone!

I'm on a small laptop with vertical window splits, so I don't have very many columns. tput cols shows 194, so one vertical split cuts that in half, then there's a | column showing the separator, then each buffer has something like 6-10 columns for error indicators, line numbers, etc… so I estimate maybe 87 columns per buffer.

Here's what the display looks like in my editor right now:

image

The error message obscures my code, including the current cursor/selection.

Reproduction Steps

I tried this:

  1. hx
  2. Split the window vertically: C-W v
  3. Edit some code to introduce an LSP error.

I expected this to happen:

I'm not sure! Obscuring either the code or the error message is confusing/annoying.

The UI I personally would prefer is for all LSP errors to appear in a separate window at the bottom of the terminal, completely out of band for the code. The location of the error would be implicit in the selection/cursor, or perhaps the left line-based error indicator would have a special color/glyph to indicate which line this new LSP message widget applies to.

Another UI option might be to have a key combo to toggle between displaying or hiding the LSP error.

My personal preference would be for a combination of these: a dedicated widget at the bottom of the terminal that I can quickly pop open or hide, depending on my needs in the moment.

(And yes, perhaps a nicer UI is just a bigger screen, but I'm on this small form factor laptop because it's so convenient to take with me on trips.)

Instead, this happened:

The LSP messages are displayed right-justified within the same buffer view as source, so it ends up obscuring the source.

Helix log

This doesn't seem relevant. All of the behavior is as-designed AFAIK. LMK if log messages are important here.

Platform

linux (crostini within ChromeOS)

Terminal Emulator

hx inside tmux inside ChromeOS Termina

Helix Version

helix 23.03 (92c328c)

@nathan-at-least nathan-at-least added the C-bug Category: This is a bug label May 10, 2023
@nathan-at-least
Copy link
Author

Ooh, while I did do a text search for this prior to filing an issue, I missed this feature in development that provides a UI that meets my needs well:

#6059 (comment)

@nathan-at-least
Copy link
Author

Will close this ticket as noise and go voice support there. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

1 participant