Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl grammar is old and unreliable #7201

Closed
jonassmedegaard opened this issue Jun 1, 2023 · 2 comments · Fixed by #7644
Closed

Perl grammar is old and unreliable #7201

jonassmedegaard opened this issue Jun 1, 2023 · 2 comments · Fixed by #7644
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@jonassmedegaard
Copy link

jonassmedegaard commented Jun 1, 2023

Summary

The default configuration points to using a tree-sitter grammar for Perl which in my experience crashes frequently, and is discouraged by related programmers.

Please consider switching to https://github.com/tree-sitter-perl/tree-sitter-perl as recommended in about comment. It has recent(!) commits from core Perl developers (oalders, leonerd).

Reproduction Steps

I have (briefly) tested that the proposed grammar works succesfully - after patching Helix to support it (see #7198 #7202).

Helix log

No response

Platform

Linux

Terminal Emulator

alacritty 0.11.0

Helix Version

helix 23.05

@jonassmedegaard jonassmedegaard added the C-bug Category: This is a bug label Jun 1, 2023
@jonassmedegaard
Copy link
Author

As also mentioned at #7200, I have in fact not verified if the alternative tree-sitter parser actually works, yet...

@jonassmedegaard
Copy link
Author

Update: I can confirm that the concretely proposed alternative tree-parser grammar does work: Removing the compiled file makes Helix not apply syntax highlighting to Perl code, which then reappears when reinstating the compiled file.

@the-mikedavis the-mikedavis added A-language-support Area: Support for programming/text languages E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants