Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching in selection mode should extend the selection until the search term #8866

Closed
cole-h opened this issue Nov 19, 2023 · 2 comments
Closed
Labels
C-enhancement Category: Improvements

Comments

@cole-h
Copy link
Contributor

cole-h commented Nov 19, 2023

This is essentially a duplicate of #6964. However, that issue was itself closed as a duplicate of #5672, which I think was due to a misinterpretation of the original issue (5672 talks about "In select mode (v/) this can be used to add matches of the search pattern as new cursors." (searching in select mode adding cursors for search results), while 6964 talks about "It changes the selection to the searched-for text., rather than extending it." (searching in select mode extending the selection until the search result)).

My imagined workflow would be:

  1. Enter selection mode at some specific location asdf in a document with v
  2. Search for e.g. fn with /fn
  3. Have the selection extend from asdf to fn (and NOT add another cursor at fn)
@cole-h cole-h added the C-enhancement Category: Improvements label Nov 19, 2023
@pascalkuthe
Copy link
Member

that is part of #5672, the issue was correctly closed as duplicate

this search would replace or extend the current selection(s) (depending on normal or select mode).

@pascalkuthe pascalkuthe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
@cole-h
Copy link
Contributor Author

cole-h commented Nov 19, 2023

My eyes really are failing me... I could have sworn I had read that ticket multiple times to try and not look silly, and here I am. Oops. Thanks for the sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants