-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Kakoune's A-S
#9459
Comments
Is anyone working on this one at the moment? I'd like to make my first contribution |
Nobody has announced that they're working on this, so it's probably fine? |
Cool! Ill give it a shot |
I'm not against this, just asking what is a usecase? The only situation I can see is something like selecting parentheses/brackets and delete them, but for that I can use existing keybinds. |
Just created a pull request for this one |
Did you have something specific in mind for this command @kirawi? I also wonder if we need a command for this given that we have surround tools builtin while Kakoune does not |
It was requested by https://matrix.to/#/!zMuVRxoqjyxyjSEBXc:matrix.org/$bFvOW3o-qWGL_cSdJWwK1wE86NXUz8LFq7rBJtO6VMA?via=matrix.org&via=mozilla.org&via=envs.net and I thought it was simple enough (and because Kakoune included it). mawww/kakoune#550 is the issue that motivated it in Kakoune. I think right now it could also be useful for basic multi-character pairs. Overall, I agree that it is a niche command and if you guys don't want to include the command I'd be indifferent to it. |
The use-cases mentioned later in the issue are covered by surround tools. The original use-case I'm not sure I fully understand but it seems like it wouldn't come up often so I bet it could be covered instead by subselecting with a regex of |
for selections that span across lines, |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
In Kakoune, it selects the first and last characters of each selection.
Where
[]
denotes a selection,[helix]
becomes[h]eli[x]
It would look similar to
helix/helix-term/src/commands.rs
Lines 1855 to 1864 in 87a720c
helix/helix-core/src/selection.rs
Lines 607 to 614 in 87a720c
The text was updated successfully, but these errors were encountered: