Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to @bifravst/aws-cdk-lambda-helpers #328

Open
coderbyheart opened this issue Apr 3, 2024 · 3 comments
Open

Migrate to @bifravst/aws-cdk-lambda-helpers #328

coderbyheart opened this issue Apr 3, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@coderbyheart
Copy link
Member

The code for packing lambdas and layers has been published as a standalone library: https://github.com/bifravst/aws-cdk-lambda-helpers

Example migration: hello-nrfcloud/backend#588
@coderbyheart coderbyheart added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 3, 2024
@coderbyheart coderbyheart mentioned this issue Apr 3, 2024
Open
@Lenakh97 Lenakh97 closed this as completed May 8, 2024
@coderbyheart
Copy link
Member Author

Which commit implemented the change @Lenakh97?

@coderbyheart coderbyheart reopened this May 8, 2024
@coderbyheart
Copy link
Member Author

Still used Lambda.Function: https://github.com/hello-nrfcloud/public-parameter-registry-aws-js/blob/saga/cdk%2FRegistryStack.ts#L94

Should use https://github.com/bifravst/aws-cdk-lambda-helpers/blob/saga/src%2FPackedLambdaFn.ts

@Lenakh97
Copy link
Contributor

Lenakh97 commented May 8, 2024

Oh okay. I thought this commit fixed it:

e062aee

I will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderbyheart @Lenakh97