-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Flow to TypeScript #8
Comments
Hey @100terres, great to see you effort on this fork! 😻 How can we support you to get this done? |
Hi @finnatinform, I’m currently working on migrating the test suit to |
We could use flowgen to help make flow types from our typescript types https://github.com/joarwilk/flowgen (I'm not a flow developer either 😅) |
@JamesGelok thank you for the suggestion! 🙂 🎉 |
Hey @100terres , just wondering if there's anything we can help with here? |
Hi @cmacdonnacha thanks for pinging me! I was a bit busy at work in the last couple weeks, but I recently managed to migrate all the files in the After that I've already started the migrations of the |
Hi there! Just to give you all feedback! Sorry, to have left this work unfinished! I'll push to finish this and really take the time to maintain this repo 🙂 Sorry again and I won't let you down this time 🙂 |
Here's an update of where we currently are:
I'll try to give you an other update in the upcoming days! |
We are now at 487 errors 🙂 📉 |
We are now at 395 TypeScript/typings errors. Just to mention the tests themselves are passing 🙂 |
We are now at 138 TypeScript errors! Almost done! 🙂 |
Will be done soon! Only 59 errors left 🙂 |
No more TypeScript errors ✔️ Next step I'll do some clean-up 🧹 |
I'll be able to do release |
The only thing missing here is the support of flow declaration: But for now it will be a nice to have. If anyone would like to tackle this issue and open a PR I'll gladly review it and merge it 🙂 This conclude the migration from flow to TypeScript! |
v14.0.0 released 🙂 |
Description
Related to: atlassian/react-beautiful-dnd#982
TypeScript
support with declaration file (Add TypeScript declaration files #3)TypeScript
(Move Storybook and stories to TypeScript #14)TypeScript
(Move our tests to TypeScript #15)TypeScript
(Move our source files to TypeScript #10)Flow
related code or definitions #131Flow
andTypeScript
#134Flow
type definition #132The text was updated successfully, but these errors were encountered: