New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test submission #21

Open

dsimandl opened this issue Sep 23, 2016 · 1 comment

dsimandl commented Sep 23, 2016

Obviously there are some assumptions made here that I'd be happy to discuss.

https://github.com/dsimandl/float-programming-test

Member

andyburke commented Sep 26, 2016

Thanks for your submission, I have a couple of points of feedback:

You should probably specify an engine requirement in the package.json since you are using default arguments and they are not supported in the latest LTS node release (4.5.0).
Your balanced parentheses check is failing to return the proper result in some cases. Consider this string for example:

(() ()

This should return false, it has an unbalanced open paren followed by sets of balanced parentheses.

(() ())

This should return true, it has balance sets of parentheses within a balanced set of parentheses.

If you'd like to update your submission, just drop a comment here afterwards. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment