Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

AllowDecline on TemplateSignatureRequest class is not translated into actual request (Status: Ready for Merge) #113

Open
andre-engelbrecht opened this issue Nov 30, 2021 · 0 comments
Labels
legacy Related to legacy, non-OpenAPI SDK

Comments

@andre-engelbrecht
Copy link

andre-engelbrecht commented Nov 30, 2021

Problem description:

The TemplateSignatureRequest class has a boolean property for AllowDecline, but in the CreateUnclaimedDraft method, this property is not added to the actual request to HelloSign's API, and thus has no effect.

Steps to reproduce:

Create a new (embedded) signature request using the CreateUnclaimedDraft method with AllowDecline = true. When you try to sign this request using the generated URL, there is no option to decline.

SDK Version

1.3.0 - there is no newer version available.

Solution to resolve

Add the following code to the CreateUnclaimedDraft method

if (signatureRequest.AllowDecline)
{
    restRequest.AddParameter("allow_decline", "1");
}

Status

Ready for Merge
Link to PR: #114

@andre-engelbrecht andre-engelbrecht changed the title AllowDecline on TemplateSignatureRequest class is not translated into actual request AllowDecline on TemplateSignatureRequest class is not translated into actual request (Status: Ready for Merge) Nov 30, 2021
@jtreminio-dropbox jtreminio-dropbox added the legacy Related to legacy, non-OpenAPI SDK label Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Related to legacy, non-OpenAPI SDK
Projects
None yet
Development

No branches or pull requests

2 participants