Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Add callback handling guide to README #16

Open
cmpaul opened this issue Oct 28, 2015 · 4 comments
Open

Add callback handling guide to README #16

cmpaul opened this issue Oct 28, 2015 · 4 comments

Comments

@cmpaul
Copy link
Contributor

cmpaul commented Oct 28, 2015

We don't have any guidance on this, let's add a section to the README.

@desmondw
Copy link
Contributor

Closing this because we have documentation regarding the handling of callbacks in our API docs and link to them in the README. https://www.hellosign.com/api/reference#Callbacks

@BHSPitMonkey
Copy link
Contributor

I'm willing to leave this open, since there's more we can do here. Currently the only PHP example on the walkthrough is computing the hash, which is just one piece of the puzzle.

@BHSPitMonkey BHSPitMonkey reopened this May 13, 2016
@garnold
Copy link
Contributor

garnold commented May 16, 2016

@BHSPitMonkey Also note that the PHP example you referenced could be simplified when using the SDK:

$event = new HelloSign\Event(json_decode($_POST['json']))
if (!is_null($event) && $event->isValid($apiKey)) {
    // do something useful
}

@josiahmann
Copy link

I'm just finishing my integration and I'll agree that documentation for this is lacking compared to the other existing documentation. Thanks for the comments though @garnold , that helped me clarify my setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants