Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symbolic icons in toolbar #122

Open
haarp opened this issue Apr 13, 2022 · 0 comments
Open

Use symbolic icons in toolbar #122

haarp opened this issue Apr 13, 2022 · 0 comments

Comments

@haarp
Copy link

haarp commented Apr 13, 2022

Hello,

Viewnior uses a few icons in its toolbar that can, with certain GTK and icon themes result in unreadable icons, such as dark-on-dark or bright-on-bright.

"Just" using bright icons on dark themes is not a good solution, as this a) Not all backgrounds are necessarily dark, and b) There will be many occasions where the bright icons will look out of place in other places/applications.

The proper way to solve this is to use symbolic icons, which are monochrome icons that will adopt the font color. Themes will set a foreground font color that provides a good contrast to the background. Having icons follow this is a clever solution.

Otherwise, users will invariably run into unreadable theme/icon combinations.

This is a sequel to #76

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant