Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Actual content in notices.json and tender.json files #59

Merged
merged 6 commits into from
Aug 24, 2020
Merged

Added Actual content in notices.json and tender.json files #59

merged 6 commits into from
Aug 24, 2020

Conversation

thisisnitish
Copy link
Contributor

@thisisnitish thisisnitish commented Aug 23, 2020 •
edited
Loading

Added actual content in the notices.json file and there are some docs and link which are not allowed so I did according to the original website and moreover there is one link which is dead so I added some random doc of any other notice. Moreover there is a notice called faculty career which is redirecting to another link so here also we didn't had doc or any other idea so for the sake of work I added another doc from the different notice.😊👍🏻

@fahad-israr
Copy link
Member

  • It's good that you've added dummy docs/other doc links where there are collisions/contradictions.
  • I am concerned about the additional dependencies that have been added. Why do you need them? Any special things that you are not available to achieve?

@thisisnitish
Copy link
Contributor Author

thisisnitish commented Aug 24, 2020 •
edited
Loading

  • No, actually I was concerned about the notices which don't have docs so I added dummy docs just for the sake of work so that the code will not break, and other than that everything is okk👍🏻. You see the pr and merge it😊.
  • For the additional dependencies, i don't know when I executed i got an error that no module name found so I searched on stack overflow and some other articles and found that run npm install again so I did that after that there was not any problem.

@fahad-israr
Copy link
Member

Thanks for clarification @thisisnitish
I am merging your PR .

@fahad-israr fahad-israr linked an issue Aug 24, 2020 that may be closed by this pull request
Start Adding actual Content #52
Open
@fahad-israr fahad-israr merged commit 6b608f4 into helloworld-iiitt:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start Adding actual Content
2 participants
@thisisnitish @fahad-israr