Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/postgresql] Wrong fullname template #21933

Closed
v-mihaylov opened this issue Apr 15, 2020 · 4 comments
Closed

[stable/postgresql] Wrong fullname template #21933

v-mihaylov opened this issue Apr 15, 2020 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@v-mihaylov
Copy link

The fullname computation in many charts is broken.
The line referenced below should read:
{{- $name | trunc 63 | trimSuffix "-" -}}

{{- .Release.Name | trunc 63 | trimSuffix "-" -}}

The issue if valid affects many other charts.

@dani8art
Copy link
Contributor

Hi @v-mihaylov, thank you for your feedback, I have to say that we are in the process of standardize this kind of mistake using [1], we will fix it sooner than later. However, we are open to contribution and if you have a chance to open a PR we will be so happy to handle it.

  1. https://github.com/bitnami/charts/blob/master/bitnami/common/templates/_names.tpl#L21

@carrodher
Copy link
Collaborator

In addition to that, given the stable deprecation timeline, this Bitnami maintained Helm chart is now located at bitnami/charts. Please visit the bitnami/charts GitHub repository to create Issues or PRs.

In this issue we tried to explain more carefully the reasons and motivations behind this transition, please don't hesitate to add a comment in this issue if you have any question related to the migration itself.

@stale
Copy link

stale bot commented May 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2020
@stale
Copy link

stale bot commented May 30, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants