Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Feature-Policy #10

Closed
Malvoz opened this issue May 29, 2020 · 3 comments
Closed

Changes to Feature-Policy #10

Malvoz opened this issue May 29, 2020 · 3 comments

Comments

@Malvoz
Copy link

Malvoz commented May 29, 2020

Just a heads-up, the experimental Feature-Policy header has been renamed, it is now Permissions-Policy. Feature-Policy will probably be supported for quite some time, for backwards-compatibility in browsers that support it today.

Relatedly, there's also the Document-Policy header.

At this point I'm not quite sure which directives defined for the initial Feature-Policy header fit into which of the new headers. I'll follow the progress and perhaps report back here, but probably best to rely on MDN documentation updates.

@EvanHahn
Copy link
Member

EvanHahn commented May 29, 2020 via email

@EvanHahn
Copy link
Member

I see three pieces to this:

  1. What should be the future of this module, feature-policy? IMO, we should keep it as is. It's worth updating the documentation to reflect deprecation (like we did with hpkp), but it's not like I'll delete the module.
  2. How should this module be included in "mainline" Helmet (the helmet npm package)? IMO, it should be completely removed from the source code in the next major version of Helmet. We could reference this package in the documentation.
  3. How should Permissions-Policy and Document-Policy be handled? I think it's too early to tell, but I'll keep an eye on them.

Does that sound reasonable?

@EvanHahn
Copy link
Member

I've thought about this a bit.

I plan to continue maintaining this module as is, even though Feature-Policy is a deprecated header. I will also be removing it from helmet version 4, which I plan to release on 2020-08-02 (a few days from now).

I've created helmetjs/helmet#234 to continue this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants