Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing vectors with index arrays #824

Open
mtar opened this issue Jun 28, 2021 · 2 comments
Open

indexing vectors with index arrays #824

mtar opened this issue Jun 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working indexing redistribution Related to distributed tensors
Milestone

Comments

@mtar
Copy link
Collaborator

mtar commented Jun 28, 2021

Description
A clear and concise description of the bug and the associated functionality.

various bugs when using index arrays for indexing on distributed one-dimensional DNDarrays.

To Reproduce
Steps to reproduce the behavior:

  1. Which module/class/function is affected?
    getitem
  2. What are the circumstances under which the bug appears?
    array indexing on distributed 1d arrays
  3. What is the exact error message / erroneous behavior?
    Runtime error / Segmentation fault

Expected behavior
A clear and concise description of what you expected to happen.
Return DNDarray with indexed values.

Illustrative
If applicable, add screenshots or minimal examples to help explain your problem.

x = ht.arange(10,1,-1, split=0)
# wrong order on procs > 2
x[ht.array([3, 3, 1, 8])]

# Segmentation fault procs > 1
x[ht.array([3,3,-3,8])]

# Runtime error procs > 1
x[ht.array([[1,1],[2,3]])]

Version Info
master f7f6c35

Additional comments
Any other comments here.
First case related to #703

Not tested yet:

  • Indexing Multi-dimensional arrays
  • masks / boolean index arrays
@mtar mtar added bug Something isn't working redistribution Related to distributed tensors labels Jun 28, 2021
@mtar mtar changed the title indexing with index arrays on vectors indexing vectors with index arrays Jun 28, 2021
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito ClaudiaComito self-assigned this Aug 21, 2023
@github-actions
Copy link
Contributor

Branch bugs/824-indexing_vectors_with_index_arrays created!

@ClaudiaComito
Copy link
Contributor

Still open, addressed in #938


reviewed within #1109

@ClaudiaComito ClaudiaComito modified the milestones: Repo Clean-Up, 1.4.0 Aug 21, 2023
@ClaudiaComito ClaudiaComito modified the milestones: 1.4.0, 1.5.0 Apr 12, 2024
@ClaudiaComito ClaudiaComito modified the milestones: 1.5.0, 1.6 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working indexing redistribution Related to distributed tensors
Projects
None yet
Development

No branches or pull requests

2 participants