-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MockModule creates mocks for imported modules which then creates conflicts #70
Comments
Hi @DaSchTour, you are right, unfortunately, that's a current limitation. Also for the proper correct testing whole environment should be mocked, except testing component. If you need to avoid a dependency from mocking, I would suggest - declare it right in the Your issue can be closed as a duplicate of #44. Once it's implemented you can specify what to mock and what to don't mock without an issue. |
Hi @DaSchTour, might you test the issue on 10.0.0-alpha.1 with the MockBuilder https://www.npmjs.com/package/ng-mocks/v/10.0.0-alpha.1#mockbuilder ? |
Hi @DaSchTour, any update? You can try improved 10.0.0-alpha.3 |
Hey, I'll have to check and find my example. Lot of work and lot of refactoring later I can't currently find it. Will need to rebuild it probably. Sorry. Hope I'll find some time for that soon. |
Totally agree, if you don't mind I would suggest to close the issue and feel free to reopen it or to submit a new one. Quite sure the issue has been fixed, because I met the same problem before. |
If you have a test for Component A which imports a module B as a mock an module C as a non mock module C is not allowed to be part of module B because then a mock for module C is generated which then creates conflicting components.
The text was updated successfully, but these errors were encountered: