Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pcapy Reader object selectable #48

Open
brianmaissy opened this issue May 17, 2018 · 0 comments
Open

Make pcapy Reader object selectable #48

brianmaissy opened this issue May 17, 2018 · 0 comments

Comments

@brianmaissy
Copy link

The python select module supports selecting on objects which provide a fileno() method. In order to allow selecting more seamlessly on Reader objects, I suggest adding a method like this:

def fileno(self):
    return self.getfd()

I'd be happy to open a PR if this sounds like something that could get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant