Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyl template --apply does not remove Backup.postgresql.cnpg.io #17

Open
NiklasRosenstein opened this issue Aug 19, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@NiklasRosenstein
Copy link
Collaborator

Master issue: #5

I have a Backup resource from CNPG and when I remove it, nyl template --apply does not cause it to be removed despite the use of ApplySets.

apiVersion: nyl.io/v1
kind: ApplySet
metadata:
  name: dbtest
  namespace: default
  annotations:
    applyset.kubernetes.io/additional-namespaces: default
    applyset.kubernetes.io/contains-group-kinds: Backup.postgresql.cnpg.io,Cluster.postgresql.cnpg.io,Secret
    applyset.kubernetes.io/tooling: kubectl/v1.30.1
  labels:                                                                                                                                                                                                                                                                                                                       
    applyset.kubernetes.io/id: applyset-udOLAc3vebT-iZJonoxsKC3Nr7c6fVeNkIdTcC5DsdM-v1                                                                                                                                                                                                                                        
@NiklasRosenstein NiklasRosenstein added the bug Something isn't working label Aug 19, 2024
@NiklasRosenstein NiklasRosenstein self-assigned this Aug 19, 2024
@NiklasRosenstein
Copy link
Collaborator Author

It also doesn't seem to remove secrets. Simple example to reproduce:

---
apiVersion: v1
kind: Namespace
metadata:
  name: sccache

---
apiVersion: inline.nyl.io/v1
kind: HelmChart
release:
  name: redis
  namespace: sccache
chart:
  # Explore the chart at https://artifacthub.io/packages/helm/bitnami/redis
  repository: https://charts.bitnami.com/bitnami
  name: redis
  version: "20.0.3"
values:
  architecture: standalone
  auth:
    enabled: true # make this "false" in the second run
  master:
    persistence:
      enabled: true
      storageClass: hcloud-volumes
      size: 64Gi

Comparison between the kubectl logs between the two nyl template --apply runs:

 applyset.nyl.io/sccache serverside-applied
 ApplySet field manager kubectl-applyset should own these fields. Retrying with conflicts forced.
 namespace/sccache serverside-applied
 networkpolicy.networking.k8s.io/redis serverside-applied
 poddisruptionbudget.policy/redis-master serverside-applied
 serviceaccount/redis-master serverside-applied
-secret/redis serverside-applied
 configmap/redis-configuration serverside-applied
 configmap/redis-health serverside-applied
 configmap/redis-scripts serverside-applied
 service/redis-headless serverside-applied
 service/redis-master serverside-applied
 statefulset.apps/redis-master serverside-applied

There is supposed to be a "pruning secret ..." log!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant