Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When filtering traffic by pod-name, if the pod cannot be found, display a message to notify the user. #205

Closed
hengyoush opened this issue Dec 21, 2024 · 2 comments · Fixed by #211
Labels
documentation Improvements or additions to documentation feature-request good first issue Good for newcomers

Comments

@hengyoush
Copy link
Owner

hengyoush commented Dec 21, 2024

Is your feature request related to a problem? Please describe.

  1. Currently on display a error log like: can not find any running pod by name xxx, we can add a message to notify the user to check Kyanos is whether running on the same machine where the pod is located.
  2. Add this case to faq docs.

Describe the solution you'd like
Add a message to notify the user to check Kyanos is whether running on the same machine where the pod is located.

Describe alternatives you've considered

Additional context

@hengyoush hengyoush added the good first issue Good for newcomers label Dec 21, 2024
@hengyoush hengyoush added the documentation Improvements or additions to documentation label Dec 21, 2024
@hengyoush hengyoush added this to v1.5.0 Dec 21, 2024
@hengyoush hengyoush moved this to Todo in v1.5.0 Dec 21, 2024
@hengyoush hengyoush added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Dec 21, 2024
@XmchxUp
Copy link
Contributor

XmchxUp commented Dec 23, 2024

I think the error message should be more general.

it just needs to add in the FAQ that only local containers are supported.

@hengyoush
Copy link
Owner Author

I think the error message should be more general.

it just needs to add in the FAQ that only local containers are supported.

I agree with you.

@XmchxUp XmchxUp mentioned this issue Dec 23, 2024
@hengyoush hengyoush moved this from Todo to In Progress in v1.5.0 Dec 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v1.5.0 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature-request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants