Nicephore integration

[LotuxPunk]

Describe the solution you'd like
Hello ! I'm Lotux, the guy behind Nicephore. Many users asked me to do basically what your mod is already doing. Which is better that I could probably done myself.

That said, I'm wondering if you're open to integration between our two mods ? I do not know yet how we can do it to be ergonomic and respect the UX of both mods, but I'd be a pleasure to work with you on that !

Describe alternatives you've considered
Cries in my sofa with a bucket of popcorn

Additional context
Nicephore repo : https://github.com/LotuxPunk/Nicephore
Nicephore CurseForge project : https://www.curseforge.com/minecraft/mc-mods/nicephore

[henkelmax]

Yeah would be nice to have these mods working with each other.
The only thing is that the images taken with the camera have a pretty low resolution and also already have a heavy jpeg compression (Or you could hook in when calling the screenshot function before compression). So some functionality of your mod would already be obsolete here. But I can imagine having the same chat message popping up when taking an image with the camera.
This should be doable without needing to change any code of the camera mod.
You can just hook into this method with a mixin and process the BufferedImage like you do with native screenshots.

If you need help with that I could make a PR to your mod.

[LotuxPunk]

The only thing is that the images taken with the camera have a pretty low resolution and also already have a heavy jpeg compression (Or you could hook in when calling the screenshot function before compression).

My idea was to probably add a "print" option to the screenshot (on the screenshot gui) and if the player has the necessary (camera + paper) I'd print the screenshot like it's a brand new photo (maybe with the date corresponding to the date of the screenshot) ?

Side effect would be that anyone could print anything on a server, which is something that I don't know if we can/want to manage or not ?

Other question, do you have some technical limitation (Image size, weight,...) documented somewhere ?

So some functionality of your mod would already be obsolete here. But I can imagine having the same chat message popping up when taking an image with the camera.

On your side, does your camera take a regular screenshot and then send it via the method you showed me ? Or it's purely the camera that take an image without passing by the "vanilla way" ?

Because if your mode use the vanilla way, we can just both share the same resource from the start and then nothing more to do is needed.

Thanks for your time !

PS: Do you have a Discord server or whatever (Twitter/GitHub isn't probably the best way to communicate quickly 😅 )?

[henkelmax]

My idea was to probably add a "print" option to the screenshot (on the screenshot gui) and if the player has the necessary (camera + paper) I'd print the screenshot like it's a brand new photo (maybe with the date corresponding to the date of the screenshot) ?

The camera mod already has an option to upload custom images, so this is definitely possible.

Other question, do you have some technical limitation (Image size, weight,...) documented somewhere ?

All images are max 1920 pixels big. Then it is converted to jpg and compressed as much as needed to send it via MCs networking.

On your side, does your camera take a regular screenshot and then send it via the method you showed me ? Or it's purely the camera that take an image without passing by the "vanilla way" ?

Yeah the mod just hides the GUI, takes a screenshot and then shows it again

My discord is henkelmax#3747