Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run on babashka #10

Closed
henryw374 opened this issue May 29, 2020 · 8 comments
Closed

run on babashka #10

henryw374 opened this issue May 29, 2020 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@henryw374
Copy link
Owner

babashka doesnt support the dot special form atm, so probably some reader conditionals would be required https://github.com/borkdude/babashka#reader-conditionals

@henryw374 henryw374 added the help wanted Extra attention is needed label May 29, 2020
@borkdude
Copy link

borkdude commented May 29, 2020

@henryw374 What dot special form doesn't work in babashka? Do you have an example? Maybe this should be fixed in babashka / sci?

@henryw374
Copy link
Owner Author

henryw374 commented May 29, 2020

ah, sorry, I saw this issue babashka/babashka#199. I see it is closed now.

for example, this field access doesn't work in babashka

(def max (. java.time.LocalDate -MAX))

but does in clojure and clojurescript. FYI The minus sign in -MAX is necessary for cljs, but happens to work in clojure as well.

this does work in bb: java.time.LocalDate/MAX

@borkdude
Copy link

I've made an issue here: babashka/sci#339
For now I would recommend using a reader conditional and use the preferred form of Class/field in the :clj branch.

@henryw374
Copy link
Owner Author

cheers

@henryw374
Copy link
Owner Author

fixed in e3d184b by adding extra reader conditionals :)

@borkdude
Copy link

Confirmed!

Screenshot 2020-05-29 19 47 34

@borkdude
Copy link

@henryw374 I decided to run the tests for this library with babashka and found a few classes that were still missing. I added those:

babashka/babashka@696d410

Should be part of the 0.1.0 release coming up soon.

@henryw374
Copy link
Owner Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants