This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
edit docs for 0.2 release #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2018 10:40
Signed-off-by: JENNIFER RONDEAU <jrondeau@heptio.com>
Signed-off-by: JENNIFER RONDEAU <jrondeau@heptio.com>
alexbrand
reviewed
May 18, 2018
discovery/README.md
Outdated
|
|
||
| ### Openstack | ||
| The Openstack discoverer monitors all Load Balancer as a Service (LBaaS) configured as well as the corresponding Members. They are synchronized to the Team namespace as Services and Endpoints, with the Namespace being configured as the TenantName in Openstack. | ||
| The Openstack Discoverer monitors all configured Load Balancers as a Service (LBaaS) plus their corresponding Members. They are synchronized to the Team namespace as Services and Endpoints. The namespace ia configured as the OpenStack TenantName. |
There was a problem hiding this comment.
typo: "The namespace ia"
|
|
||
| During the discovery process, Gimbal translates the discovered backends into | ||
| Kubernetes Services and Endpoints. The name of the discovered Services and |
There was a problem hiding this comment.
The "Discovered Name" is a concept that gets mentioned a couple of more times in this document. Not sure if we should maintain the definition of "Discovered Name" here?
Signed-off-by: JENNIFER RONDEAU <jrondeau@heptio.com>
Signed-off-by: JENNIFER RONDEAU <jrondeau@heptio.com>
|
LGTM! |
|
Also looks good to me! |
rosskukulinski
added a commit
that referenced
this pull request
May 21, 2018
edit docs for 0.2 release Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JENNIFER RONDEAU jrondeau@heptio.com
Copyedits: