This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
discovery: make gimbal client request rate limit configurable #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
This PR makes the client request rate limits against the Gimbal kubernetes API server configurable via command-line flags on both the kubernetes and openstack discoverers.
New flags:
--gimbal-client-qps
--gimbal-client-burst
I decided to go with the client-go defaults, which means that the user will most likely always want to set these flags when deploying Gimbal.
With that said, it might be worth setting defaults that are higher, but I am not sure what those would be. I am also interested in feedback on the flags themselves and the description/documentation.