Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

discovery: make gimbal client request rate limit configurable #151

Merged
merged 2 commits into from
Jun 15, 2018

Conversation

alexbrand
Copy link
Contributor

Fixes #150

This PR makes the client request rate limits against the Gimbal kubernetes API server configurable via command-line flags on both the kubernetes and openstack discoverers.

New flags:

flag default description
--gimbal-client-qps 5 The maximum queries per second (QPS) that can be performed on the Gimbal Kubernetes API server
--gimbal-client-burst 10 The maximum number of queries that can be performed on the Gimbal Kubernetes API server during a burst

I decided to go with the client-go defaults, which means that the user will most likely always want to set these flags when deploying Gimbal.

With that said, it might be worth setting defaults that are higher, but I am not sure what those would be. I am also interested in feedback on the flags themselves and the description/documentation.

Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@stevesloka
Copy link
Member

I think having them configurable is good as a first step and some of the performance testing will help to come up with values we can recommend.

The only thing we could possibly document better is when to tweak one vs the other. Like what is burst and when does it come in to play? Otherwise LGTM.

@alexbrand
Copy link
Contributor Author

Sounds good! I'll add some more documentation around QPS and burst to the discoverer docs.

Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@alexbrand
Copy link
Contributor Author

Added documentation on qps and burst. I hope I am on the right track, but would love some feedback.

@stevesloka stevesloka merged commit 3ab51a2 into projectcontour:master Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants