Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Minor cleanup of deployment docs #170

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Minor cleanup of deployment docs #170

merged 2 commits into from
Jun 28, 2018

Conversation

rosskukulinski
Copy link
Contributor

  • Grafana no longer needs to be configured to talk to prometheus
  • Grafana dashboards are pre-configured
  • Change doc label selector to pickup all backends

Signed-off-by: Ross Kukulinski ross@kukulinski.com

@alexbrand
Copy link
Contributor

Do we want to get rid of the addition of the sample kubernetes dashboard? I guess each organization will most likely have their preferred k8s dashboard.

@rosskukulinski Do you mind rebasing?

* Grafana no longer needs to be configured to talk to prometheus
* Grafana dashboards are pre-configured
* Change doc label selector to pickup all backends

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
@rosskukulinski
Copy link
Contributor Author

@alexbrand rebased and updated table of contents (I had already removed the sample k8s dashboard)

Copy link
Contributor

@alexbrand alexbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbrand alexbrand merged commit 28f651a into master Jun 28, 2018
@alexbrand alexbrand deleted the deployment-docs branch June 28, 2018 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants